Building github pull request

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Building github pull request

Viktor Tarasov-3
Hello,

now the github pull requests (PR) to OpenSC/OpenSC are/can-be checked automatically for building on Ubuntu and Vista.
At the moment this feature is installed to help the contributors to reveal the compilation errors
on the platforms that they do not used to manage (mostly Windows).

Some restrictions in permissions to run the build on the PR's merged repository
are due to the implementation of jenkins plugin "Github pull request builder" [1]:
- PRs from the github OpenSC organization members are built automatically, these members are 'admins';
- PRs from the users present in the CI internal 'whitelist' are built automatically;
- for the PRs from the other contributors jenkins CI adds the PR comment "Can one of the admins verify this patch?"
   to attract the attention of 'admins';
- using the codified comments to PR, 'admins' can add user to the 'whitelist' or (re)run the test;

Codified messages:
- "ok to test" -- authorization to run the test on merged repository;
- "add to whitelist" -- add user to whitelist;



Examples:

PR-#97 [2]:
- pull request fails the build of merged repository on windows-32;
- user 'mtausig' is added by 'admin' to internal CI 'whitelist', so that,
  the next PRs or updates of existing PRs from 'mtausig' will be built automatically.

PR-#102 [3]:
- successful built of the merged repository.



If you consider that all these restrictions are too complicated,
we will install the modified version of the jenkins plugin to unconditionally build all PRs.


Kind regards,
Viktor.


[1] https://wiki.jenkins-ci.org/display/JENKINS/Github+pull+request+builder+plugin
[2] https://github.com/OpenSC/OpenSC/pull/97
[3] https://github.com/OpenSC/OpenSC/pull/102<https://github.com/OpenSC/OpenSC/pull/97>
_______________________________________________
opensc-devel mailing list
[hidden email]
http://www.opensc-project.org/mailman/listinfo/opensc-devel