Fwd: breaking autoconf build system

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: breaking autoconf build system

Alon Bar-Lev
Hello Viktor,

Recently you renamed configure.ac to configure.ac.in in order to
substitute some variables in autoconf.

This is breaking autoconf, as standard package should not contain any
additional configuration but the configuration script, all that is
required is:

git clone xxx
cd xxxx
autoreconf -ivf

Not sure where this was discussed, but as I am available and have the
most commits within build system, please CC me on these changes.

What we need to do now is:

1. revert this change.

2. remove the bootstrap script, it is not required, if you want you
can leave a script with "autoreconf -ivf" command.

3. add version information within Makefile.am to create version.h with
the information required from git (example[1])

4. in any case, instead of sed of configure.ac, you can always create
version.m4 and include it at configure.ac (examples[2][3]).

Regards,
Alon

[1] https://github.com/OpenVPN/openvpn/blob/master/Makefile.am#L92
[2] https://github.com/OpenVPN/openvpn/blob/master/configure.ac#L29
[3] https://github.com/OpenVPN/openvpn/blob/master/version.m4

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: breaking autoconf build system

Viktor Tarasov-3
Hello Alon,

On 02/21/2014 07:30 PM, Alon Bar-Lev wrote:

> Recently you renamed configure.ac to configure.ac.in in order to
> substitute some variables in autoconf.
>
> This is breaking autoconf, as standard package should not contain any
> additional configuration but the configuration script, all that is
> required is:
>
> git clone xxx
> cd xxxx
> autoreconf -ivf
>
> Not sure where this was discussed, but as I am available and have the
> most commits within build system, please CC me on these changes.
>
> What we need to do now is:
>
> 1. revert this change.
>
> 2. remove the bootstrap script, it is not required, if you want you
> can leave a script with "autoreconf -ivf" command.
>
> 3. add version information within Makefile.am to create version.h with
> the information required from git (example[1])
>
> 4. in any case, instead of sed of configure.ac, you can always create
> version.m4 and include it at configure.ac (examples[2][3]).

Ok,
I will try to re-implement it using your approach.

>
> Regards,
> Alon
>
> [1] https://github.com/OpenVPN/openvpn/blob/master/Makefile.am#L92
> [2] https://github.com/OpenVPN/openvpn/blob/master/configure.ac#L29
> [3] https://github.com/OpenVPN/openvpn/blob/master/version.m4
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
> http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
> _______________________________________________
> Opensc-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/opensc-devel
>


------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel