Pull requests are piling up

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Pull requests are piling up

Andreas Schwier (ML)
Hi everyone,

who's currently in charge of processing pull requests (And who has the
privilege to apply pull requests) ?

Viktor ? Are you around ?

Andreas

--

    ---------    CardContact Software & System Consulting
   |.##> <##.|   Andreas Schwier
   |#       #|   Schülerweg 38
   |#       #|   32429 Minden, Germany
   |'##> <##'|   Phone +49 571 56149
    ---------    http://www.cardcontact.de
                 http://www.tscons.de
                 http://www.openscdp.org
                 http://www.smartcard-hsm.com


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Pull requests are piling up

William Roberts
I know Doug handled my pull request #270, but I also have #280 sitting
there (just submitted) and I don't think Doug will be able to address
it in the very near term.

On Thu, Sep 4, 2014 at 9:01 AM, Andreas Schwier
<[hidden email]> wrote:

> Hi everyone,
>
> who's currently in charge of processing pull requests (And who has the
> privilege to apply pull requests) ?
>
> Viktor ? Are you around ?
>
> Andreas
>
> --
>
>     ---------    CardContact Software & System Consulting
>    |.##> <##.|   Andreas Schwier
>    |#       #|   Schülerweg 38
>    |#       #|   32429 Minden, Germany
>    |'##> <##'|   Phone +49 571 56149
>     ---------    http://www.cardcontact.de
>                  http://www.tscons.de
>                  http://www.openscdp.org
>                  http://www.smartcard-hsm.com
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> Opensc-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/opensc-devel



--
Respectfully,

William C Roberts

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Pull requests are piling up

Ludovic Rousseau
In reply to this post by Andreas Schwier (ML)
2014-09-04 18:01 GMT+02:00 Andreas Schwier <[hidden email]>:
> Hi everyone,

Hello,

> who's currently in charge of processing pull requests (And who has the
> privilege to apply pull requests) ?
>
> Viktor ? Are you around ?

OpenSC owners are listed at https://github.com/orgs/OpenSC/teams/owners
- Martin Paljak
- Ludovic Rousseau
- Viktor Tarasov

OpenSC maintainers are listed at
https://github.com/orgs/OpenSC/teams/opensc-maintainers
- Jean-Pierre Szikora
- Doug Engert

Concerning myself I have no time nor motivation to review OpenSC patches.

One solution is to add new members to the OpenSC maintainers list.
Andreas, do you want to become an OpenSC maintainer?
Martin, Viktor, are you OK with adding Andreas Schwier as maintainer?

Bye

--
 Dr. Ludovic Rousseau

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Pull requests are piling up

Viktor Tarasov-3
Hi,


On Fri, Sep 5, 2014 at 10:31 AM, Ludovic Rousseau <[hidden email]> wrote:
Martin, Viktor, are you OK with adding Andreas Schwier as maintainer?

I have no objections.

I will try to review (some) PRs this weekend.
Probably then we should publish next minor release.  
 

Bye

Kind regards,
Viktor.

 

--
 Dr. Ludovic Rousseau

------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Pull requests are piling up

Ludovic Rousseau
2014-09-05 13:08 GMT+02:00 Viktor Tarasov <[hidden email]>:

> Hi,
>
>
> On Fri, Sep 5, 2014 at 10:31 AM, Ludovic Rousseau
> <[hidden email]> wrote:
>>
>> Martin, Viktor, are you OK with adding Andreas Schwier as maintainer?
>
>
> I have no objections.

OK.
I added "CardContact" in the OpenSC maintainers team.
https://github.com/orgs/OpenSC/teams/opensc-maintainers

Regards,

--
 Dr. Ludovic Rousseau

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Pull requests are piling up

Douglas E Engert
In reply to this post by Viktor Tarasov-3


On 9/5/2014 6:08 AM, Viktor Tarasov wrote:

> Hi,
>
>
> On Fri, Sep 5, 2014 at 10:31 AM, Ludovic Rousseau <[hidden email] <mailto:[hidden email]>> wrote:
>
>     Martin, Viktor, are you OK with adding Andreas Schwier as maintainer?
>
>
> I have no objections.
>
> I will try to review (some) PRs this weekend.
> Probably then we should publish next minor release.

#260 and #270 - look OK to me.

#241 I have questions as  shared code by all cards is modified. I believe could be done in the individual card drivers.

#283 I believe is a misunderstanding on how the RSA padding and hashing flags should be set in card and pkcs15 card drivers
and framework-pkcs15.c should not need to be modified, as the modification applies to all cards.


>
>     Bye
>
>
> Kind regards,
> Viktor.
>
>
>     --
>       Dr. Ludovic Rousseau
>
>     ------------------------------------------------------------------------------
>     Slashdot TV.
>     Video for Nerds.  Stuff that matters.
>     http://tv.slashdot.org/
>     _______________________________________________
>     Opensc-devel mailing list
>     [hidden email] <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/opensc-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
>
>
>
> _______________________________________________
> Opensc-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/opensc-devel
>

--

  Douglas E. Engert  <[hidden email]>


------------------------------------------------------------------------------
Slashdot TV.  Video for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Opensc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opensc-devel