Re: [opensc-commits] svn opensc changed [2503] Make the pcsc pinpad option work. [u]

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [opensc-commits] svn opensc changed [2503] Make the pcsc pinpad option work. [u]

Andreas Jellinghaus-2
On Sunday 21 August 2005 20:44, [hidden email] wrote:
> Revision: 2503
> Author:   martin
> Date:     2005-08-21 18:44:07 +0000 (Sun, 21 Aug 2005)

I'm not sure why that extra priority field in _get_conf_block is needed.
can you explain?

Thanks, Andreas
_______________________________________________
opensc-devel mailing list
[hidden email]
http://www.opensc.org/cgi-bin/mailman/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Re: [opensc-commits] svn opensc changed [2503] Make the pcsc pinpad option work. [u]

Martin Paljak
On 8/21/05, Andreas Jellinghaus [c] <[hidden email]> wrote:
> I'm not sure why that extra priority field in _get_conf_block is needed.
> can you explain?

IIRC it worked like this: currently opensc makes use of two blocks:
one with app name default and the other one with the actual
application name used to create the context. In theory this field
would then allow to specify if you want the more 'generig' or default
option or one from the application block. In practice i just used this
small function to get rid of some similar repeated for cycles in the
code.

--
Martin Paljak
[hidden email]
http://martin.paljak.pri.ee/
+372.5156495 - phone
_______________________________________________
opensc-devel mailing list
[hidden email]
http://www.opensc.org/cgi-bin/mailman/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Re: [opensc-commits] svn opensc changed [2503] Make the pcsc pinpad option work. [u]

Nils Larsch
Martin Paljak wrote:

> On 8/21/05, Andreas Jellinghaus [c] <[hidden email]> wrote:
>
>>I'm not sure why that extra priority field in _get_conf_block is needed.
>>can you explain?
>
>
> IIRC it worked like this: currently opensc makes use of two blocks:
> one with app name default and the other one with the actual
> application name used to create the context. In theory this field
> would then allow to specify if you want the more 'generig' or default
> option or one from the application block. In practice i just used this
> small function to get rid of some similar repeated for cycles in the
> code.

Btw: if you consider this function useful, why not put it into
src/scconf/ ?

Nils
_______________________________________________
opensc-devel mailing list
[hidden email]
http://www.opensc.org/cgi-bin/mailman/listinfo/opensc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Re: [opensc-commits] svn opensc changed [2503] Make the pcsc pinpad option work. [u]

Andreas Jellinghaus-2
In reply to this post by Martin Paljak
On Sunday 21 August 2005 23:35, Martin Paljak wrote:

> On 8/21/05, Andreas Jellinghaus [c] <[hidden email]> wrote:
> > I'm not sure why that extra priority field in _get_conf_block is needed.
> > can you explain?
>
> IIRC it worked like this: currently opensc makes use of two blocks:
> one with app name default and the other one with the actual
> application name used to create the context. In theory this field
> would then allow to specify if you want the more 'generig' or default
> option or one from the application block. In practice i just used this
> small function to get rid of some similar repeated for cycles in the
> code.

so you are using this to get the value from the generic block,
even though there is a value in the specific block? why?

I detect documenting this detail is necessary and not easy.

also "0" and "1" are not very nice values.
what about enum types with names that explain what
happens?

this code is a typical example of additional complexity,
so if we can somehow avoid it by improving scconf in general
or not needing this feature, that would be preferable to me.

Regards, Andreas
_______________________________________________
opensc-devel mailing list
[hidden email]
http://www.opensc.org/cgi-bin/mailman/listinfo/opensc-devel